Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apis to support s3/sftp datasources import #499

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

nianiaJR
Copy link
Contributor

@nianiaJR nianiaJR commented Mar 7, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@nianiaJR nianiaJR added the wip Solution: work in progress label Mar 7, 2023
@nianiaJR nianiaJR requested a review from hetao92 March 7, 2023 06:36
@nianiaJR nianiaJR changed the title feat: apis to support s3/sftp datasources import (WIP)feat: apis to support s3/sftp datasources import Mar 7, 2023
@wey-gu
Copy link
Contributor

wey-gu commented Mar 7, 2023

looking forward to this feature so very much❤

@nianiaJR nianiaJR force-pushed the import-support-s3 branch from cb5500d to 2d45ae8 Compare March 7, 2023 11:27
hetao92
hetao92 previously approved these changes Mar 9, 2023
Copy link
Contributor

@hetao92 hetao92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hetao92 hetao92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hetao92 hetao92 merged commit cb89b8b into vesoft-inc:master Mar 9, 2023
@wey-gu wey-gu changed the title (WIP)feat: apis to support s3/sftp datasources import feat: apis to support s3/sftp datasources import Mar 9, 2023
@wey-gu wey-gu added the doc affected PR: improvements or additions to documentation label Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation wip Solution: work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants