fix: fix empty props in template import #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huaxiabuluo
reviewed
Dec 29, 2022
app/pages/Console/ExportModal.tsx
Outdated
Comment on lines
34
to
43
| ? tables.reduce((acc, cur) => { | ||
| if (cur.type === 'vertex') { | ||
| acc.push(cur.vid); | ||
| } else { | ||
| vertexIds.forEach(id => { | ||
| acc.push(cur[id].toString()); | ||
| }); | ||
| } | ||
| return acc; | ||
| }, []).filter(vertexId => vertexId !== '') |
There was a problem hiding this comment.
tables.reduce((acc, cur) => {
if (cur.type === 'vertex') {
cur.vid && acc.push(cur.vid);
} else {
vertexIds.forEach(id => {
acc.push(cur[id].toString());
});
}
return acc;
}, [])
Comment on lines
17
to
27
| const [data, setData] = useState<{ | ||
| list: { | ||
| Type: string, | ||
| Name: string, | ||
| Count: number, | ||
| }[], | ||
| total: { | ||
| vertices: number, | ||
| edges: number, | ||
| } | null | ||
| } | null>(null); |
There was a problem hiding this comment.
const [data, setData] = useState<{
list: { Type: string; Name: string; Count: number }[];
total?: { vertices: number; edges: number };
}>({ list: [], total: undefined });
Comment on lines
66
to
79
| const _data = data.tables.reduce((prev, cur) => { | ||
| if (cur.Type === 'Space') { | ||
| if(!prev.total) { | ||
| prev.total = { | ||
| vertex: 0, | ||
| edge: 0, | ||
| }; | ||
| } | ||
| prev.total[cur.Name] = cur.Count; | ||
| } else { | ||
| prev.list.push(cur); | ||
| } | ||
| return prev; | ||
| }, { list: [], total: null }); |
There was a problem hiding this comment.
const nextData = data.tables.reduce((prev, cur) => {
if (cur.Type === 'Space') {
prev.total ||= { vertex: 0, edge: 0 };
prev.total[cur.Name] = cur.Count;
} else {
prev.list.push(cur);
}
return prev;
}, { list: [], total: undefined } as typeof data });| // empty props in yaml will converted to null, but its required in nebula-importer | ||
| parseContent.files.forEach(file => { | ||
| if(file.schema.edge) { | ||
| file.schema.edge.props = file.schema.edge?.props || []; |
There was a problem hiding this comment.
file.schema.edge.props ||= [];
| } | ||
| if(file.schema.vertex) { | ||
| file.schema.vertex?.tags.forEach(tag => { | ||
| tag.props = tag.props || []; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: