Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bugs #250

Merged
merged 1 commit into from
Jul 6, 2022
Merged

fix: fix bugs #250

merged 1 commit into from
Jul 6, 2022

Conversation

hetao92
Copy link
Contributor

@hetao92 hetao92 commented Jul 5, 2022

No description provided.

@hetao92
Copy link
Contributor Author

hetao92 commented Jul 5, 2022

fix #214 #249

Comment on lines 79 to 85
let sessionErrMsg;
_results.data?.some(i => {
if(i.code === -1 && i.message.includes('Session not existed')) {
sessionErrMsg = i.message;
return true;
}
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const errMsg = _results.data?.find((i) => i.code === -1 && i.message?.includes('Session not existed'))?.message;

mod: code review

mod: code review
Copy link
Contributor

@huaxiabuluo huaxiabuluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hetao92 hetao92 merged commit d90c972 into vesoft-inc:master Jul 6, 2022
@hetao92 hetao92 deleted the hetao-dev branch July 6, 2022 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants