Refactor #213
Merged
Refactor #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
veeding
force-pushed
the
refactor
branch
2 times, most recently
from
416ca11 to
2ace00c
Compare
veezhang
reviewed
May 17, 2022
| "github.com/vesoft-inc/nebula-studio/server/api/studio/internal/service" | ||
| "net/http" |
| @@ -10,6 +10,7 @@ import ( | |||
| "github.com/saintfish/chardet" | |||
| "github.com/vesoft-inc/nebula-studio/server/api/studio/internal/svc" | |||
| "github.com/vesoft-inc/nebula-studio/server/api/studio/internal/types" | |||
| Config "github.com/vesoft-inc/nebula-studio/server/api/studio/pkg/config" | |||
There was a problem hiding this comment.
The alias of pkg usually lowercase. And this pkg will be removed.
Comment on lines
50
to
53
| func WithSessionMessage(err error, formatWithArgs ...interface{}) error { | ||
| ErrSessionWithMessage := newErrCode(CCUnauthorized, PlatformCode, 1, fmt.Sprintf("ErrSession::%s", err.Error())) | ||
| return WithCode(ErrSessionWithMessage, err, formatWithArgs...) | ||
| } |
There was a problem hiding this comment.
Only very general ones are put here, this is not recommended to be put here, this file should not be easily changed.
You just need to define the new ErrCode after line 12 // Define you error code here.
| "wmv": "video/x-ms-wmv", | ||
| "avi": "video/x-msvideo", | ||
| // dynamicly add query params to the request | ||
| func AddQueryParams(r *http.Request, params map[string]string) { |
There was a problem hiding this comment.
Modified the original query parameter, it seems strange, is there a better way?
| post /api/file/upload | ||
| @doc "delete file" | ||
| @handler FileDestroy | ||
| delete /api/file/:name(FileDestroyRequest) |
There was a problem hiding this comment.
How about /api/files/:name ?
| delete /api/file/:name(FileDestroyRequest) | ||
| @doc "preview file" | ||
| @handler FilesIndex | ||
| get /api/file returns(FilesIndexData) |
|
please resolve conflicts. |
huaxiabuluo
force-pushed
the
refactor
branch
2 times, most recently
from
21ef801 to
85ea357
Compare
veezhang
reviewed
May 18, 2022
| get /api/import-tasks/stop/:id(StopImportTaskRequest) | ||
| @doc "Download logs" | ||
| @handler DownloadLogs | ||
| get /api/import-tasks/download/logs/:id(DownloadLogsRequest) |
There was a problem hiding this comment.
How about /api/import-tasks/:id/download-logs ?
| get /api/import-tasks/download/logs/:id(DownloadLogsRequest) | ||
| @doc "Download Config" | ||
| @handler DownloadConfig | ||
| get /api/import-tasks/download/config/:id(DownloadConfigsRequest) |
There was a problem hiding this comment.
How about /api/import-tasks/:id/download-config?
veezhang
reviewed
May 18, 2022
server-v2/api/studio/studio.go
Outdated
| if strings.HasPrefix(r.URL.Path, "/api/files") { | ||
| return false | ||
| } | ||
| if strings.HasPrefix(r.URL.Path, "/api/import-tasks/download") { |
There was a problem hiding this comment.
There are several places with this logic, can you encapsulated into a function?
veeding
force-pushed
the
refactor
branch
4 times, most recently
from
a0deae0 to
d208aa2
Compare
veezhang
approved these changes
May 18, 2022
| @@ -0,0 +1,29 @@ | |||
| package common | |||
There was a problem hiding this comment.
Please use a more appropriate file name.
modify upload and download mody: go mod refine the code update: make check motify api modify return values rename fix
hetao92
pushed a commit
that referenced
this pull request
May 26, 2022
modify upload and download mody: go mod refine the code update: make check modify return values
hetao92
pushed a commit
that referenced
this pull request
May 26, 2022
feat: mime && connectdb store u 文件上传、删除、预览功能实现 (#206) feat: middleware (#208) * feat: middleware * feat: dynamicly add query params func * feat: common params * update: go mod tidy * feat: batchExec complete file and import task (#213) modify upload and download mody: go mod refine the code update: make check modify return values Refactor (#219) * update: server-v2 * updata: format feat: context auth (#220) update: export module (#222) feat: export RegisterHandlers (#223) update: gitignore (#224) fix: fix service init crash (#225) update: WithErrorMessage (#226) fix import task (#227) fix the type conveersion problem fix: fix import & file model (#229)
huaxiabuluo
added a commit
that referenced
this pull request
May 26, 2022
feat: mime && connectdb feat: 文件上传、删除、预览功能实现 (#206) feat: middleware (#208) * feat: middleware * feat: dynamicly add query params func * feat: common params * update: go mod tidy * feat: batchExec complete file and import task (#213) modify upload and download mody: go mod refine the code update: make check modify return values Refactor (#219) * update: server-v2 * updata: format feat: context auth (#220) update: export module (#222) feat: export RegisterHandlers (#223) update: gitignore (#224) fix: fix service init crash (#225) update: WithErrorMessage (#226) fix import task (#227) fix the type conveersion problem fix: fix import & file model (#229) Co-authored-by: Bruce <[email protected]>
veeding
added a commit
to veeding/nebula-studio
that referenced
this pull request
Jun 14, 2022
modify upload and download mody: go mod refine the code update: make check modify return values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
complete import task and pass all test