Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix import map #173

Merged
merged 1 commit into from
Apr 1, 2022
Merged

fix: fix import map #173

merged 1 commit into from
Apr 1, 2022

Conversation

hetao92
Copy link
Contributor

@hetao92 hetao92 commented Apr 1, 2022

No description provided.

@hetao92 hetao92 requested a review from mizy April 1, 2022 07:48
Comment on lines +266 to +269
const tags = this.verticesConfig[configIndex].tags;
const _tag = { ...tags[tagIndex] };
_tag.props[propIndex][field!] = value;
tags.splice(tagIndex, 1, _tag);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tags, _tag.props[propIndex][field!] are certain truthy ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

Copy link
Contributor

@huaxiabuluo huaxiabuluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hetao92 hetao92 merged commit 8d64470 into vesoft-inc:master Apr 1, 2022
@hetao92 hetao92 deleted the hetao-fix branch April 1, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants