feat: init task log #144
Merged
feat: init task log #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huaxiabuluo
reviewed
Mar 14, 2022
| "viewLogs": "View Logs", | ||
| "details": "Details", | ||
| "lines": "Lines", | ||
| "task": "import task", |
There was a problem hiding this comment.
Import Task or import task ?
Comment on lines
55
to
69
| if(currentLog!.name === 'import.log') { | ||
| const res = await getImportLogDetail({ | ||
| offset: offset.current, | ||
| taskId: id, | ||
| path: currentLog!.path | ||
| }); | ||
| handleLogData(res); | ||
| } else { | ||
| const res = await getErrLogDetail({ | ||
| offset: offset.current, | ||
| taskId: id, | ||
| path: currentLog!.path | ||
| }); | ||
| handleLogData(res); | ||
| } |
There was a problem hiding this comment.
const getLogDetail = currentLog!.name === 'import.log' ? getImportLogDetail : getErrLogDetail;
const res = await getLogDetail({
offset: offset.current,
taskId: id,
path: currentLog!.path
});
handleLogData(res);
app/pages/Import/TaskList/index.tsx
Outdated
| const handleTaskStop = useCallback(async(id: number) => { | ||
| clearTimeout(timer.current); | ||
| const { code } = await stopTask(id); | ||
| if(code === 0) { | ||
| message.success(intl.get('import.stopImportingSuccess')); | ||
| await asyncGetTaskList(); | ||
| await getTaskList(); |
app/pages/Import/TaskList/index.tsx
Outdated
| } | ||
| }, []); | ||
| const handleTaskDelete = useCallback(async(id: number) => { | ||
| clearTimeout(timer.current); | ||
| const { code } = await deleteTask(id); | ||
| if(code === 0) { | ||
| message.success(intl.get('import.deleteSuccess')); | ||
| await asyncGetTaskList(); | ||
| await getTaskList(); |
There was a problem hiding this comment.
last line of a function, unnecessary await
Comment on lines
+112
to
+117
| {modalVisible && <LogModal | ||
| logDimension={logDimension} | ||
| onCancel={() => setVisible(false)} | ||
| visible={modalVisible} />} |
There was a problem hiding this comment.
be equal
{modalVisible && (
<LogModal
visible
logDimension={logDimension}
onCancel={() => setVisible(false)}
/>
)}
app/stores/import.ts
Outdated
Comment on lines
95
to
97
| document.body.appendChild(link); | ||
| link.click(); | ||
| document.body.removeChild(link); |
There was a problem hiding this comment.
just link.click() also woks ?
hetao92
force-pushed
the
hetao-task
branch
2 times, most recently
from
743a693 to
e5222b1
Compare
feat: add log read mod: change key mod: code review mod: add template import mod: code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.