Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update index page #131

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Conversation

hetao92
Copy link
Contributor

@hetao92 hetao92 commented Feb 25, 2022

No description provided.

@hetao92 hetao92 requested a review from huaxiabuluo February 25, 2022 07:09
<div
{...provided.droppableProps}
ref={provided.innerRef}
style={getListStyle()}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use constant instead of function ?

name,
});
if (res.code === 0) {
await getRebuildData(type);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary await

@@ -37,7 +37,7 @@ const Schema = () => {
if (!err) {
history.push(`/schema/${space}/tag/list`);
} else if (err && err.toLowerCase().includes('spacenotfound')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err is certain truthy

mod: code review
@hetao92 hetao92 merged commit 8cde9f5 into vesoft-inc:v3.3.0-dev Feb 28, 2022
@hetao92 hetao92 deleted the hetao-index branch February 28, 2022 08:53
hetao92 added a commit to hetao92/nebula-studio that referenced this pull request Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants