feat: init schema & space create page #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mizy
reviewed
Feb 21, 2022
| const { code, data } = (await service.execNGQL({ | ||
| gql: `DESCRIBE SPACE ${handleKeyword(space)}`, | ||
| })) as any; | ||
| return { code, data }; | ||
| } | ||
|
|
||
| asyncGetSpacesList = async(_payload) => { | ||
| getSpacesList = async() => { | ||
| const res = await this.getSpaces(); | ||
| if (res.data) { | ||
| const spaces: ISpace[] = []; |
There was a problem hiding this comment.
why not get spaces from globalStore?
There was a problem hiding this comment.
and there is a useless const spaces?
mizy
reviewed
Feb 21, 2022
|
|
||
|
|
||
|
|
||
| const Schema = () => { |
mizy
reviewed
Feb 21, 2022
| }, | ||
| ...numberRulesFn(intl), | ||
| ]}> | ||
| <Input /> |
There was a problem hiding this comment.
Input maybe need a placeholder
huaxiabuluo
reviewed
Feb 21, 2022
| @@ -31,16 +31,24 @@ const itemRender = (route, _params, routes, _paths) => { | |||
| ); | |||
| }; | |||
|
|
|||
| const Breadcrumb: React.FC<IProps> = (props: IProps) => { | |||
| const NebulaBreadcrumb: React.FC<IProps> = (props: IProps) => { | |||
| const { routes, ExtraNode } = props; | |||
There was a problem hiding this comment.
better to use extraNode ?
Comment on lines
+68
to
+70
| const list = [...keyWords, ...operators, ...ban].filter(item => { | ||
| return item.indexOf(str) === 0; | ||
| }); |
There was a problem hiding this comment.
const list = [...keyWords, ...operators, ...ban].filter(item => item.startsWith(str));
Comment on lines
+112
to
+116
| blur = instance => { | ||
| if (this.props.onBlur) { | ||
| this.props.onBlur(instance.doc.getValue()); | ||
| } | ||
| }; |
There was a problem hiding this comment.
it's more elegant to use optional chaining instead of a && a.b && a.b()
blur = instance => this.props.onBlur?.(instance.doc.getValue());
hetao92
force-pushed
the
hetao-schema
branch
from
80e8e58 to
9c390e2
Compare
mod: code review mod: code review
hetao92
force-pushed
the
hetao-schema
branch
from
9c390e2 to
a8e418c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.