Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

Use compiled common to build storage #87

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Conversation

yixinglu
Copy link
Contributor

avoid nebula graph and storage compile same common sources.

@yixinglu yixinglu added wip Solution: work in progress ready-for-testing PR: ready for the CI test and removed wip Solution: work in progress labels Jul 10, 2020
dutor
dutor previously approved these changes Jul 13, 2020
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dangleptr
Copy link
Contributor

You could create link to your common dir under src/module. And switch off the ENABLE_UPDATE.

Copy link
Contributor

@monadbobo monadbobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@dangleptr dangleptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Well done.

@dangleptr dangleptr merged commit d8562cc into master Jul 13, 2020
@dangleptr dangleptr deleted the use-compiled-common branch July 13, 2020 09:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants