This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
fix balance thread hang up #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
darionyaphet,
linkensphere201,
liuyu85cn,
bright-starry-sky and
panda-sheep
| p.setValue(Status::OK()); | ||
| } else { | ||
| p.setValue(Status::Error("Access kv failed, code: %s", | ||
| apache::thrift::util::enumNameSafe(code).c_str())); |
There was a problem hiding this comment.
sorry to say alignment.
There was a problem hiding this comment.
😂 my poor vscode, hold on
darionyaphet
approved these changes
Jun 22, 2021
| @@ -43,8 +43,8 @@ void HBProcessor::process(const cpp2::HBReq& req) { | |||
| } | |||
| } | |||
|
|
|||
| VLOG(3) << "Receive heartbeat from " << host | |||
| << ", role = " << apache::thrift::util::enumNameSafe(req.get_role()); | |||
| LOG(INFO) << "Receive heartbeat from " << host | |||
There was a problem hiding this comment.
Previously was INFO, modified to VLOG(3) by others. It is the most convenient way to tell which is meta leader.
| @@ -315,7 +315,7 @@ void FileBasedWal::closeCurrFile() { | |||
| timebuf.modtime = currInfo_->mtime(); | |||
| timebuf.actime = currInfo_->mtime(); | |||
| VLOG(1) << "Close cur file " << currInfo_->path() << ", mtime: " << currInfo_->mtime(); | |||
| CHECK_EQ(utime(currInfo_->path(), &timebuf), 0); | |||
There was a problem hiding this comment.
what's reason? no need to check the system error?
liuyu85cn
approved these changes
Jun 23, 2021
This was referenced Jun 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If future's callback is invoked before the future is set. And in the callback, baton will wait forever.