This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
Fixed nebula-common dependency #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the build will work even without building the nebula-comon in advance
sherman-the-tank
requested review from
dutor,
yixinglu,
CPWstatic,
dangleptr and
laura-ding
sherman-the-tank
changed the title
laura-ding
reviewed
Mar 3, 2020
| SET(NEBULA_COMMON_PACKAGE "nebula-common") | ||
|
|
||
| # Configure the dependent projects | ||
| include(AddDependentProject) |
There was a problem hiding this comment.
I can't see the AddDependentProject.cmake file.
laura-ding
approved these changes
Mar 5, 2020
CPWstatic
approved these changes
Mar 6, 2020
sherman-the-tank
added a commit
that referenced
this pull request
Mar 31, 2020
sherman-the-tank
added a commit
that referenced
this pull request
Mar 31, 2020
* Fixed bebula-common dependency Now the build will work even without building the nebula-comon in advance * Added missing file
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the build will work even without building the nebula-comon in advance