Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

Use new property type #30

Merged
merged 3 commits into from
May 20, 2020
Merged

Use new property type #30

merged 3 commits into from
May 20, 2020

Conversation

laura-ding
Copy link
Contributor

No description provided.

dangleptr
dangleptr approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@dangleptr dangleptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally, lgtm.
By the way, the meta.thrift changes has been merged in common yet?

@laura-ding
Copy link
Contributor Author

@dangleptr meta.thrift no change.

@dangleptr dangleptr added the ready-for-testing PR: ready for the CI test label May 15, 2020
panda-sheep
panda-sheep approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@dangleptr dangleptr merged commit 7a60cb2 into vesoft-inc:master May 20, 2020
@yixinglu yixinglu deleted the schema branch May 28, 2020 06:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@panda-sheep panda-sheep panda-sheep approved these changes

@dangleptr dangleptr dangleptr approved these changes

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laura-ding @dangleptr @panda-sheep