refactor index key utils #12
Conversation
bright-starry-sky
requested review from
darionyaphet,
sherman-the-tank,
critical27,
dangleptr,
liuyu85cn and
panda-sheep
src/common/IndexKeyUtils.h
Outdated
| } | ||
| return std::move(v); |
|
Addressed dangleptr's comments. |
| CHECK_GE(rawKey.size(), kVertexIndexLen); | ||
| auto offset = rawKey.size() - sizeof(VertexIntID); | ||
| return *reinterpret_cast<const VertexIntID*>(rawKey.data() + offset); | ||
| static VertexIDSlice getIndexVertexID(size_t vIdLen, const folly::StringPiece& rawKey) { |
There was a problem hiding this comment.
If so seems we don't need VertexIntID ?
There was a problem hiding this comment.
If so seems we don't need
VertexIntID?
Yes, we don't need VertexIntID ， the vIdLen should be 8 if this is nebula1.0 data.
| .append(reinterpret_cast<const char*>(&indexId), sizeof(IndexID)); | ||
| indexRaw(values, key); | ||
| key.append(srcId.data(), srcId.size()) | ||
| .append(vIdLen - srcId.size(), '\0') |
There was a problem hiding this comment.
The zero filling will arise at here ? I mean for example: when we define the vertex size is 6 and current vertex ID is ABCD the graph service will send ABCD\0\0 or ABCD ?
There was a problem hiding this comment.
The zero filling will arise at here ? I mean for example: when we define the vertex size is 6 and current vertex ID is
ABCDthe graph service will sendABCD\0\0orABCD?
The graph service should send ABCD, then storage service will convert it to fixed length vid ABCD\0\0
|
Please rebase on the master |
rebased done. |
| case Value::Type::INT : | ||
| return encodeInt64(v.getInt()); | ||
| case Value::Type::FLOAT : | ||
| return encodeDouble(v.getFloat()); |
There was a problem hiding this comment.
encodeDouble is too good，👍
refactor index key utils. using Value instead of VariantType.