Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ngql reader #78

Merged
merged 1 commit into from
Jan 9, 2023
Merged

support ngql reader #78

merged 1 commit into from
Jan 9, 2023

Conversation

Nicole00
Copy link
Contributor

@Nicole00 Nicole00 commented Jan 4, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

support read edge data through the query statement.

How do you solve it?

use just one spark partition to execute the query, get the edge data in ResultSet by iterator. And convert the edge Value in query ResultSet to Spark DataFrame edge.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

the query is not distributed in spark layer. Please make sure the query's result is edges result. For the usage, please see NebulaSparkReaderExample.scala

@Nicole00 Nicole00 added the doc affected PR: improvements or additions to documentation label Jan 4, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 50.54% // Head: 44.67% // Decreases project coverage by -5.87% ⚠️

Coverage data is based on head (843229f) compared to base (0e037b7).
Patch coverage: 7.52% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #78      +/-   ##
============================================
- Coverage     50.54%   44.67%   -5.88%     
  Complexity      123      123              
============================================
  Files            27       30       +3     
  Lines          1460     1672     +212     
  Branches        241      280      +39     
============================================
+ Hits            738      747       +9     
- Misses          645      846     +201     
- Partials         77       79       +2     
Impacted Files Coverage Δ
...la/com/vesoft/nebula/connector/NebulaOptions.scala 0.00% <0.00%> (ø)
...nnector/reader/NebulaNgqlEdgePartitionReader.scala 0.00% <0.00%> (ø)
...soft/nebula/connector/reader/NebulaPartition.scala 66.66% <0.00%> (-33.34%) ⬇️
...t/nebula/connector/reader/NebulaSourceReader.scala 85.71% <0.00%> (-7.39%) ⬇️
...nebula/connector/reader/NebulaNgqlEdgeReader.scala 0.00% <0.00%> (ø)
...vesoft/nebula/connector/reader/NebulaNgqlRDD.scala 0.00% <0.00%> (ø)
...esoft/nebula/connector/reader/NebulaRelation.scala 87.50% <33.33%> (-3.81%) ⬇️
...ala/com/vesoft/nebula/connector/NebulaConfig.scala 56.86% <55.17%> (-0.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nicole00 Nicole00 merged commit abf030e into vesoft-inc:master Jan 9, 2023
@Nicole00 Nicole00 deleted the ngql_reader branch January 9, 2023 07:23
@Nicole00 Nicole00 restored the ngql_reader branch January 9, 2023 07:23
@Nicole00 Nicole00 deleted the ngql_reader branch January 9, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants