doc: pyspark write example #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
=========================================
Coverage 74.09% 74.09%
Complexity 153 153
=========================================
Files 24 24
Lines 1594 1594
Branches 256 256
=========================================
Hits 1181 1181
Misses 266 266
Partials 147 147 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This was referenced Aug 23, 2022
Closed
Nicole00
reviewed
Aug 24, 2022
Nicole00
reviewed
Aug 24, 2022
| "graphAddress", "graphd1:9669").option( | ||
| "passwd", "nebula").option( | ||
| "writeMode", "delete").option( | ||
| "user", "root").save() |
There was a problem hiding this comment.
well done! great example!
| val RANK_AS_PROP: String = "rankAsProp" | ||
| val WRITE_MODE: String = "writeMode" | ||
| val DELETE_EDGE: String = "deleteEdge" | ||
| ``` |
There was a problem hiding this comment.
should we post the option's datatype here?
There was a problem hiding this comment.
Do you mean we should add things like bool for deleteEdge or? Should we expose those options here or not?
There was a problem hiding this comment.
We could add comment inline on supported value/type like(assuming # is a valid comment string for scala)?
val RANK_AS_PROP: String = "rankAsProp" # bool, i.e. true
val WRITE_MODE: String = "writeMode" # string, i.e. 'update', 'insert', 'delete'
val DELETE_EDGE: String = "deleteEdge" # bool, i.e. trueThere was a problem hiding this comment.
We could add comment inline on supported value/type like(assuming # is a valid comment string for scala)?
val RANK_AS_PROP: String = "rankAsProp" # bool, i.e. true val WRITE_MODE: String = "writeMode" # string, i.e. 'update', 'insert', 'delete' val DELETE_EDGE: String = "deleteEdge" # bool, i.e. true
Yeah, great way. The information for options is enough now.
This was referenced Aug 27, 2022
Nicole00
added a commit
that referenced
this pull request
Aug 31, 2022
* pyspark example added (#51) * pyspark example added * Update README_CN.md * support delete related edges when delete vertex (#53) * support delete related edges when delete vertex * add test * add example for delete vertex with edge (#54) * doc: pyspark write example (#55) * doc: pyspark write example * Added pyshell calling lines and python file header discussed in #50 Thanks to @Reid00 * Update README.md wording * Update README_CN.md * Update README.md * Update README_CN.md * Update README.md * Update README_CN.md * spark2.2 reader initial commit * spark2.2 reader initial commit * extract common config for multi spark version * delete common config files * extract common config and utils * remove common test * spark connector reader for spark 2.2 * spark connector writer for spark 2.2 * revert example * refactor spark version & close metaProvider after finish writing * refactor common package name * fix scan part * refactor spark version for spark2.2 * connector writer for spark2.2 Co-authored-by: Wey Gu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as titled