Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support TLS for session pool #360

Merged
merged 3 commits into from
Aug 9, 2024
Merged

feat: support TLS for session pool #360

merged 3 commits into from
Aug 9, 2024

Conversation

BeautyyuYanli
Copy link
Contributor

@BeautyyuYanli BeautyyuYanli commented Aug 9, 2024

Since NebulaGraph Cloud requires TLS connection

@wey-gu wey-gu changed the title support SSL for session pool support TLS for session pool Aug 9, 2024
@BeautyyuYanli BeautyyuYanli requested a review from Nicole00 August 9, 2024 09:37
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.14%. Comparing base (8560e0e) to head (63b4a92).

Files Patch % Lines
nebula3/gclient/net/SessionPool.py 85.71% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #360      +/-   ##
==========================================
- Coverage   75.36%   75.14%   -0.23%     
==========================================
  Files          19       19              
  Lines        2724     2724              
==========================================
- Hits         2053     2047       -6     
- Misses        671      677       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Nicole00 Nicole00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great feature!

@wey-gu wey-gu merged commit 0f832f6 into master Aug 9, 2024
10 checks passed
@wey-gu wey-gu deleted the yanli/fix_ssl branch August 9, 2024 09:55
@wey-gu wey-gu mentioned this pull request Aug 9, 2024
@wey-gu wey-gu changed the title support TLS for session pool feat: support TLS for session pool Aug 9, 2024
wey-gu pushed a commit that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants