Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ResultSet.py #343

Merged
merged 2 commits into from
May 10, 2024
Merged

Update ResultSet.py #343

merged 2 commits into from
May 10, 2024

Conversation

sherif-abdelkarim
Copy link
Contributor

Fixes a bug where the tuple (src_id, dst_id, rank, edge_name) is used as the a key when accessing edges_dict, instead of the string representation of the tuple.

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Fixes a bug where the tuple (src_id, dst_id, rank, edge_name) is used as the a key when accessing edges_dict, instead of the string representation of the tuple.
@CLAassistant
Copy link

CLAassistant commented May 9, 2024

CLA assistant check
All committers have signed the CLA.

@wey-gu
Copy link
Contributor

wey-gu commented May 9, 2024

Dear @sherif-abdelkarim ,

Great catch, and thanks!

Welcome to the NebulaGraph Community!

Would you mind signing the CLA(by clicking above CLA badge) then we could merge your contributions then :D

@sherif-abdelkarim
Copy link
Contributor Author

Hello @wey-gu ,
Thank you!
I just signed the CLA

@wey-gu wey-gu merged commit 0fd9278 into vesoft-inc:master May 10, 2024
10 checks passed
wey-gu pushed a commit that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants