fix: support conn_pool ping before init | add missing dep in py3.6 #339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In NebulaGraph repo ci test, ping was done before the connection pool's init, this was broken in recent changes.
This change fixed it.
issue 1:
a. connection_pool cannot be ping() without init()
b. dependency issue:
httpcore-->anyio
BUT NOTcontextvars
WHY this issue(a, or b) was not found? It could be due to a dirty cache, see issue 2 hided issue 1.
Action: added this dep handling in setup.py
issue 2:
dirty cache in gh runner in
/home/vesoft/actions-runner/_work/_temp/_github_home/.local
WHY
.local
exist unexpected nebula3-python package? It could be caused by attempts of pip3 install --user:And in
vesoft-inc/nebua
, it's doing so(install 3.5.1 withpip3 install --user
Action: force to remove unexpected nebula3-python packages before installation first, we need to ensure .local is cleaned in runner cache.