Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a base class for functions execute_* #338

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

BeautyyuYanli
Copy link
Contributor

In this PR,

  • Add a base class named BaseExecutor, to be inherited by Session and Session Pool, which have the same functions execute_*
  • fix typing ;
  • pdm run fmt ;

@CLAassistant
Copy link

CLAassistant commented Apr 24, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 81.63265% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 75.63%. Comparing base (6895832) to head (bb218fa).
Report is 3 commits behind head on master.

Files Patch % Lines
nebula3/gclient/net/ConnectionPool.py 75.00% 4 Missing ⚠️
nebula3/gclient/net/Session.py 77.77% 2 Missing ⚠️
nebula3/gclient/net/base.py 85.71% 2 Missing ⚠️
nebula3/gclient/net/Connection.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
- Coverage   76.88%   75.63%   -1.26%     
==========================================
  Files          18       19       +1     
  Lines        2514     2647     +133     
==========================================
+ Hits         1933     2002      +69     
- Misses        581      645      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wey-gu
Copy link
Contributor

wey-gu commented Apr 26, 2024

Thanks!!!! This'll fix pain in our ass of pylance/pyright typing warnings on downstream projects(Yes GenAI Suite!).

LGTM, but on the safe side, due to ci dependency on nebula-ent side(master branch T__T), I'll manually verify build with this branch and come back afterward :-D

@wey-gu wey-gu merged commit c2c489c into vesoft-inc:master Apr 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants