support auth for scan #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #321 +/- ##
==========================================
+ Coverage 77.50% 77.52% +0.01%
==========================================
Files 18 18
Lines 2485 2496 +11
==========================================
+ Hits 1926 1935 +9
- Misses 559 561 +2 ☔ View full report in Codecov by Sentry. |
HarrisChu
reviewed
Mar 4, 2024
| @@ -42,6 +44,13 @@ def __init__(self, meta_cache, storage_addrs=None, time_out=60000): | |||
| self._connections = [] | |||
| self._create_connection() | |||
|
|
|||
| def set_userPasswd(self, user, passwd): | |||
There was a problem hiding this comment.
good, already refactor it.
HarrisChu
reviewed
Mar 4, 2024
| @@ -225,6 +234,9 @@ def _scan_vertex( | |||
| req.filter = where | |||
| req.only_latest_version = only_latest_version | |||
| req.enable_read_from_follower = enable_read_from_follower | |||
| req.username = self.user.encode('utf-8') | |||
| req.password = self.passwd.encode('utf-8') | |||
| req.need_authenticate = True | |||
There was a problem hiding this comment.
need_authenticate is useful for storaged to distinguish the request source is graphd or clients. if the request source is clients, it will config true, and if the request source is graphd, it does not need to auth.
HarrisChu
previously approved these changes
Mar 4, 2024
HarrisChu
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only useful for enterprise