add version selection #305
Conversation
|
|
|
SessionPool config need to add config handshakeKey |
javaGitHub2022
force-pushed
the
version
branch
from
59ec9d0 to
6cffd71
Compare
javaGitHub2022
force-pushed
the
version
branch
from
b8711df to
aac8c80
Compare
javaGitHub2022
force-pushed
the
version
branch
from
e0605e8 to
45e0573
Compare
javaGitHub2022
force-pushed
the
version
branch
from
0e496ef to
0dc5f38
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #305 +/- ##
==========================================
+ Coverage 77.83% 78.02% +0.18%
==========================================
Files 18 18
Lines 2423 2430 +7
==========================================
+ Hits 1886 1896 +10
+ Misses 537 534 -3 ☔ View full report in Codecov by Sentry. |
javaGitHub2022
force-pushed
the
version
branch
from
f684cd8 to
8aee222
Compare
javaGitHub2022
force-pushed
the
version
branch
from
8dc7be8 to
1dee2c4
Compare
example/SessinPoolExample.py
Outdated
| if __name__ == "__main__": | ||
| ip = "127.0.0.1" | ||
| port = 9669 | ||
|
|
||
| handshakeKey = "3.0.0" |
There was a problem hiding this comment.
the example does not use the config handshakeKey.
nebula3/gclient/net/Connection.py
Outdated
| """open the SSL connection | ||
|
|
||
| :param ip: the server ip | ||
| :param port: the server port | ||
| :param timeout: the timeout for connect and execute | ||
| :param handshakeKey: the server version |
There was a problem hiding this comment.
handshakeKey: the key for client and server handshake, make sure the handshakeKey is in the white list config of server: client_white_list
| self._configs.idle_time != 0 | ||
| and connection.idle_time() > self._configs.idle_time | ||
| ): | ||
| if self._configs.idle_time != 0: |
There was a problem hiding this comment.
why remove the condition for idle_time?
There was a problem hiding this comment.
Accidentally deleted
| @@ -15,14 +23,15 @@ | |||
|
|
|||
| AddrIp = ["127.0.0.1", "::1"] | |||
| port = 9669 | |||
| handshakeKey = "3.0.0" | |||
There was a problem hiding this comment.
please add some tests for wrong handshakeKey value, such as "INVALID_HANDSHAKE_KEY"
close #299