Make tag param optional for Node properties method #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wey-gu
previously approved these changes
Jan 5, 2024
wey-gu
approved these changes
Jan 5, 2024
haoxins
force-pushed
the
feat-optional-tag-for-props
branch
from
78b9d08 to
b211826
Compare
HarrisChu
approved these changes
Jan 5, 2024
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #302 +/- ##
==========================================
- Coverage 77.97% 77.88% -0.09%
==========================================
Files 18 18
Lines 2415 2419 +4
==========================================
+ Hits 1883 1884 +1
- Misses 532 535 +3 ☔ View full report in Codecov by Sentry. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
closes #300
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: