fix session._connection none error

[liuxiaocs7]

close #249

[codecov-commenter]

Codecov Report

Base: 77.48% // Head: 77.11% // Decreases project coverage by -0.36% ⚠️

Coverage data is based on head (9bb2de3) compared to base (f028dfc).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
- Coverage   77.48%   77.11%   -0.37%     
==========================================
  Files          18       18              
  Lines        2407     2408       +1     
==========================================
- Hits         1865     1857       -8     
- Misses        542      551       +9     

Impacted Files	Coverage Δ
nebula3/gclient/net/SessionPool.py	71.61% <0.00%> (-0.31%)	⬇️
nebula3/mclient/__init__.py	69.23% <0.00%> (-2.68%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Aiee]

Hello @liuxiaocs7

Thank you for bringing this to us.

When we release a session here we want to make sure two things: 1. the session is logged out 2. the connection is closed. The fix you proposed here didn't deal with the connection. You could just save the connection to a variable before releasing the session and close the connection later. Something like :

conn = session._connection
session.release()
conn.close()

[liuxiaocs7]

Hello @liuxiaocs7

Thank you for bringing this to us.

When we release a session here we want to make sure two things: 1. the session is logged out 2. the connection is closed. The fix you proposed here didn't deal with the connection. You could just save the connection to a variable before releasing the session and close the connection later. Something like :

conn = session._connection
session.release()
conn.close()

Thanks for your kindly reply, got it, i'll fix

[Aiee]

LGTM.