Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unusable connection if connection Ping() failed #247

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Dec 9, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

As title.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@Aiee Aiee added the type/bug Type: something is unexpected label Dec 9, 2022
@Aiee Aiee changed the title Remove unusable connection if connection Ping() failed [DO NOT MERGE] Remove unusable connection if connection Ping() failed Dec 9, 2022
@Aiee Aiee merged commit 2406793 into vesoft-inc:v2.6.1 Dec 9, 2022
@Aiee Aiee changed the title [DO NOT MERGE] Remove unusable connection if connection Ping() failed Remove unusable connection if connection Ping() failed Dec 12, 2022
Aiee added a commit to Aiee/nebula-python that referenced this pull request Jan 11, 2023
…vesoft-inc#247)

* rRemove unusable connection if connectino Ping() failed

* Fix typo
Aiee added a commit that referenced this pull request Jan 11, 2023
* [DO NOT MERGE] Remove unusable connection if connection Ping() failed (#247)

* rRemove unusable connection if connectino Ping() failed

* Fix typo

* [v2.6.1 patch] Refactor connection pool and add more tests (#251)

* Add more tests

* Tune tests and refactor

Lower concurrence for ci so the github action can pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant