Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed cast of as_node and as_relationship #227

Merged
merged 2 commits into from
Oct 15, 2022
Merged

Fixed cast of as_node and as_relationship #227

merged 2 commits into from
Oct 15, 2022

Conversation

wey-gu
Copy link
Contributor

@wey-gu wey-gu commented Oct 14, 2022

UT added, too

@wey-gu wey-gu requested a review from Aiee October 14, 2022 11:27
Aiee
Aiee reviewed Oct 14, 2022
View reviewed changes
Copy link
Contributor

@Aiee Aiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried the examples? We better add these examples to CI like other SDKs to make sure that the demo code is always valid.

requirements/example.in Outdated Show resolved Hide resolved
@wey-gu
Copy link
Contributor Author

wey-gu commented Oct 15, 2022

Tried the simple one and it worked.

True, the example could be added in another pr.

@wey-gu
Copy link
Contributor Author

wey-gu commented Oct 15, 2022

created issue #228 for introducing example validation in ci

@Aiee Aiee merged commit 5254be2 into vesoft-inc:master Oct 15, 2022
@wey-gu wey-gu deleted the fix-cast-and-formatresp branch October 16, 2022 00:06
@wey-gu wey-gu mentioned this pull request Oct 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aiee Aiee Aiee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wey-gu @Aiee