Set lower bound version for install requirements #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wey-gu
approved these changes
Dec 26, 2022
Codecov ReportBase: 77.45% // Head: 77.45% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #155 +/- ##
=======================================
Coverage 77.45% 77.45%
=======================================
Files 18 18
Lines 2408 2408
=======================================
Hits 1865 1865
Misses 543 543 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
please @Aiee @HarrisChu let's merge it :) |
|
The concern we had is that if a lower boundary is specified, some users may need to update the package to use nebula-python. Since it's been quite a while since this PR was proposed, It should be good for most users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a best practice to set a lower bound version for install requirements. I'm not sure what's the minimum compatible versions for this project, so I used the latest major versions.