Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging is not defined #277

Closed
Lincyaw opened this issue Jul 2, 2023 · 3 comments
Closed

logging is not defined #277

Lincyaw opened this issue Jul 2, 2023 · 3 comments

Comments

@Lincyaw
Copy link
Contributor

Lincyaw commented Jul 2, 2023

https://github.com/vesoft-inc/nebula-python/blob/master/nebula3/gclient/net/ConnectionPool.py

In this file, logging is not defined. It will be triggered when server crashed due to the large memory usage.
@wey-gu
Copy link
Contributor

wey-gu commented Jul 3, 2023

https://github.com/vesoft-inc/nebula-python/blob/master/nebula3/gclient/net/ConnectionPool.py

In this file, logging is not defined. It will be triggered when server crashed due to the large memory usage.

Dear @Lincyaw , sorry for this! would you mind PR to replace logging with logger?

Thanks!

@Lincyaw Lincyaw mentioned this issue Jul 4, 2023
Closed
Lincyaw added a commit to Lincyaw/nebula-python that referenced this issue Jul 4, 2023
@Lincyaw
fix: issue vesoft-inc#277, logging is not defined
fd6ac58
@Lincyaw Lincyaw mentioned this issue Jul 4, 2023
Merged
@Lincyaw
Copy link
Contributor Author

Lincyaw commented Jul 4, 2023

#280

I have created the PR~

Nicole00 pushed a commit that referenced this issue Jul 5, 2023
@Lincyaw
fix: issue #277, logging is not defined (#280)
c53a43e
@wey-gu
Copy link
Contributor

wey-gu commented Jul 5, 2023

Thanks a lot @Lincyaw for the contribution, again :D closing it.

@wey-gu wey-gu closed this as completed Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wey-gu @Lincyaw