Fix json format (#145)

vesoft-inc · Sep 28, 2021 · e5c719f · e5c719f
1 parent 136f006
commit e5c719f
Show file tree

Hide file tree

Showing 2 changed files with 57 additions and 44 deletions.
diff --git a/nebula2/gclient/net/Session.py b/nebula2/gclient/net/Session.py
@@ -65,52 +65,58 @@ def execute_json(self, stmt):
             Date and Datetime will be returned in UTC
             JSON struct:
             {
-              "results":[
+                "results": [
                 {
-                  "columns":[],
-                  "data":[
+                    "columns": [],
+                    "data": [
                     {
-                      "row":row-data,
-                      "meta":metadata]
+                        "row": [
+                        "row-data"
+                        ],
+                        "meta": [
+                        "metadata"
+                        ]
                     }
-                  ],
-                  "latencyInUs":0,
-                  "spaceName":"",
-                  "planDesc ":{
-                    "planNodeDescs":[
-                      {
-                        "name":"",
-                        "id":0,
-                        "outputVar":"",
-                        "description":{
-                          "key":""
+                    ],
+                    "latencyInUs": 0,
+                    "spaceName": "",
+                    "planDesc ": {
+                    "planNodeDescs": [
+                        {
+                        "name": "",
+                        "id": 0,
+                        "outputVar": "",
+                        "description": {
+                            "key": ""
                         },
-                        "profiles":[
-                          {
-                            "rows":1,
-                            "execDurationInUs":0,
-                            "totalDurationInUs":0,
-                            "otherStats":{}
-                          }
+                        "profiles": [
+                            {
+                            "rows": 1,
+                            "execDurationInUs": 0,
+                            "totalDurationInUs": 0,
+                            "otherStats": {}
+                            }
                         ],
-                        "branchInfo":{
-                          "isDoBranch":false,
-                          "conditionNodeId":-1
+                        "branchInfo": {
+                            "isDoBranch": false,
+                            "conditionNodeId": -1
                         },
-                        "dependencies":[]
-                      }
+                        "dependencies": []
+                        }
                     ],
-                    "nodeIndexMap":{},
-                    "format":"",
-                    "optimize_time_in_us":0
-                  },
-                  "comment ":"",
-                  "errors":{
-                    "errorCode":0,
-                    "errorMsg":""
-                  }
+                    "nodeIndexMap": {},
+                    "format": "",
+                    "optimize_time_in_us": 0
+                    },
+                    "comment ": ""
+                }
+                ],
+                "errors": [
+                {
+                    "code": 0,
+                    "message": ""
                 }
-              ]
+                ]
             }
 
         :param stmt: the ngql

diff --git a/tests/test_data_from_server.py b/tests/test_data_from_server.py
@@ -249,12 +249,19 @@ def test_path_type(self):
 
 class TestExecuteJson(TestBaseCase):
     def test_basic_types(self):
-        resp = self.session.execute_json('YIELD 1, 2.2, "hello", [1,2,"abc"], {key: "value"}, "汉字"')
-        exp = [1, 2.2, "hello", [1,2,"abc"], {"key": "value"}, "汉字"]
+        resp = self.session.execute_json(
+            'YIELD 1, 2.2, "hello", [1,2,"abc"], {key: "value"}, "汉字"')
+        exp = [1, 2.2, "hello", [1, 2, "abc"], {"key": "value"}, "汉字"]
         json_obj = json.loads(resp)
+
+	# Get errorcode
+        resp_error_code = json_obj["errors"][0]["code"]
+        assert 0 == resp_error_code
+
+        # Get data
         assert exp == json_obj["results"][0]["data"][0]["row"]
 
-        #Get space name
+        # Get space name
         respSpace = json_obj["results"][0]["spaceName"]
         assert "test_data" == respSpace
 
@@ -285,10 +292,10 @@ def test_error(self):
 
         json_obj = json.loads(resp)
 
-        error_code = "E_SEMANTIC_ERROR"
-        resp_error_code = json_obj["results"][0]["errors"]["errorCode"]
+        error_code = -1009
+        resp_error_code = json_obj["errors"][0]["code"]
         assert error_code == resp_error_code
 
         error_msg = "SemanticError: `invalidTag': Unknown tag"
-        resp_error_msg = json_obj["results"][0]["errors"]["errorMsg"]
+        resp_error_msg = json_obj["errors"][0]["message"]
         assert error_msg == resp_error_msg