Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update imagePullPolicy to Always #70

Merged
merged 5 commits into from
Sep 18, 2021
Merged

update imagePullPolicy to Always #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
81cbe35
cancel doc/helm update
kqzh Sep 2, 2021
6f5e20f
update vesrsion
kqzh Sep 3, 2021
e83956a
Merge branch 'master' of github.com:vesoft-inc/nebula-operator into m…
kqzh Sep 17, 2021
50b00a2
Merge branch 'master' of github.com:vesoft-inc/nebula-operator into m…
kqzh Sep 17, 2021
186f33f
update imagePullPolicy to Always
kqzh Sep 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apis/apps/v1alpha1/nebulacluster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ type NebulaClusterSpec struct {
// +optional
EnablePVReclaim *bool `json:"enablePVReclaim,omitempty"`

// +kubebuilder:default=IfNotPresent
// +kubebuilder:default=Always
ImagePullPolicy *corev1.PullPolicy `json:"imagePullPolicy,omitempty"`

// +optional
Expand Down
2 changes: 1 addition & 1 deletion charts/nebula-cluster/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
nebula:
version: v2.0.1
imagePullPolicy: IfNotPresent
imagePullPolicy: Always
storageClassName: ""
schedulerName: default-scheduler # nebula-scheduler
reference:
Expand Down
2 changes: 1 addition & 1 deletion charts/nebula-operator/crds/nebulacluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ spec:
type: string
type: object
imagePullPolicy:
default: IfNotPresent
default: Always
type: string
imagePullSecrets:
items:
Expand Down
6 changes: 3 additions & 3 deletions charts/nebula-operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
image:
nebulaOperator:
image: vesoft/nebula-operator:latest
imagePullPolicy: IfNotPresent
imagePullPolicy: Always
kubeRBACProxy:
image: gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0
imagePullPolicy: IfNotPresent
imagePullPolicy: Always
kubeScheduler:
image: k8s.gcr.io/kube-scheduler:v1.18.8
imagePullPolicy: IfNotPresent
imagePullPolicy: Always

imagePullSecrets: []
kubernetesClusterDomain: ""
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/apps.nebula-graph.io_nebulaclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ spec:
type: string
type: object
imagePullPolicy:
default: IfNotPresent
default: Always
type: string
imagePullSecrets:
items:
Expand Down
2 changes: 1 addition & 1 deletion config/samples/apps_v1alpha1_nebulacluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,4 @@ spec:
name: statefulsets.apps
version: v1
schedulerName: default-scheduler
imagePullPolicy: IfNotPresent
imagePullPolicy: Always
2 changes: 1 addition & 1 deletion doc/user/nebula_cluster_helm_guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ The following table lists is the configurable parameters of the chart and their
|:---------|:-----------|:-------|
| `nameOverride` | Override the name of the chart | `nil` |
| `nebula.version` | Nebula version | `v2.0.1` |
| `nebula.imagePullPolicy` | Nebula image pull policy | `IfNotPresent` |
| `nebula.imagePullPolicy` | Nebula image pull policy | `Always` |
| `nebula.storageClassName` | PersistentVolume class, default to use the default StorageClass | `nil` |
| `nebula.schedulerName` | Scheduler for nebula component | `default-scheduler` |
| `nebula.reference` | Reference for nebula component | `{"name": "statefulsets.apps", "version": "v1"}` |
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/nebulacluster/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ import (
)

func getNebulaCluster(runtimeClient client.Client, namespace, name string) *v1alpha1.NebulaCluster {
imagePullPolicy := corev1.PullIfNotPresent
imagePullPolicy := corev1.PullAlways
storageClassName := getStorageClassName(runtimeClient)
nebulaVersion := e2econfig.TestConfig.NebulaVersion
return &v1alpha1.NebulaCluster{
Expand Down