-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coredump management #524
Merged
Merged
Coredump management #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaByte875
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kevinliu24
added a commit
that referenced
this pull request
Sep 16, 2024
* Add pv and pvc for coredump management * Add coredump preservation to helm chart crd * Fix bug in pvc provisioning * Fix flag for coredump volume * Add coredump management container * Add script to manage old coredumps * update default value for amount of time coredump is kept * fix issues in coredump management script * Fix issues in coredump logging and make it less spammy. * Fix shell script * Fix bug in expiration time and fix default value * fix go mod and go sum * update go mod and go sum * fix go mod and go sum * fix go mod and go sum
MegaByte875
pushed a commit
that referenced
this pull request
Sep 18, 2024
* [operator] Add pdb (#521) * Add pod disruption budget feature (pdb) * Fix bugs and refactor pdb template * Fix issue with range statement in pdbs.yaml * Fix error message * Fix pdbs.yaml * Revert refactor for pdbs.yaml so pdb can be for 2 components at the same time. * Fix bug for maxUnavailable * Handle percentage for min available correctly in pdb * Add default value for max unavailable * Coredump management (#524) * Add pv and pvc for coredump management * Add coredump preservation to helm chart crd * Fix bug in pvc provisioning * Fix flag for coredump volume * Add coredump management container * Add script to manage old coredumps * update default value for amount of time coredump is kept * fix issues in coredump management script * Fix issues in coredump logging and make it less spammy. * Fix shell script * Fix bug in expiration time and fix default value * fix go mod and go sum * update go mod and go sum * fix go mod and go sum * fix go mod and go sum * Fix compatibility issues with go 1.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
https://nebula-graph.atlassian.net/browse/NGSR-166
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: