Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coredump management #524

Merged
merged 16 commits into from
Sep 12, 2024
Merged

Coredump management #524

merged 16 commits into from
Sep 12, 2024

Conversation

kevinliu24
Copy link
Contributor

@kevinliu24 kevinliu24 commented Aug 28, 2024

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

https://nebula-graph.atlassian.net/browse/NGSR-166

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@kevinliu24 kevinliu24 changed the base branch from master to release-1.8 August 28, 2024 21:19
@kevinliu24 kevinliu24 self-assigned this Aug 28, 2024
@kevinliu24 kevinliu24 marked this pull request as ready for review September 10, 2024 07:37
Copy link
Contributor

@MegaByte875 MegaByte875 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
apis/apps/v1alpha1/nebulacluster_common.go Show resolved Hide resolved
@MegaByte875 MegaByte875 merged commit 8c13da1 into release-1.8 Sep 12, 2024
1 check passed
@kevinliu24 kevinliu24 deleted the coredump_management branch September 16, 2024 21:20
kevinliu24 added a commit that referenced this pull request Sep 16, 2024
* Add pv and pvc for coredump management

* Add coredump preservation to helm chart crd

* Fix bug in pvc provisioning

* Fix flag for coredump volume

* Add coredump management container

* Add script to manage old coredumps

* update default value for amount of time coredump is kept

* fix issues in coredump management script

* Fix issues in coredump logging and make it less spammy.

* Fix shell script

* Fix bug in expiration time and fix default value

* fix go mod and go sum

* update go mod and go sum

* fix go mod and go sum

* fix go mod and go sum
MegaByte875 pushed a commit that referenced this pull request Sep 18, 2024
* [operator] Add pdb (#521)

* Add pod disruption budget feature (pdb)

* Fix bugs and refactor pdb template

* Fix issue with range statement in pdbs.yaml

* Fix error message

* Fix pdbs.yaml

* Revert refactor for pdbs.yaml so pdb can be for 2 components at the same time.

* Fix bug for maxUnavailable

* Handle percentage for min available correctly in pdb

* Add default value for max unavailable

* Coredump management (#524)

* Add pv and pvc for coredump management

* Add coredump preservation to helm chart crd

* Fix bug in pvc provisioning

* Fix flag for coredump volume

* Add coredump management container

* Add script to manage old coredumps

* update default value for amount of time coredump is kept

* fix issues in coredump management script

* Fix issues in coredump logging and make it less spammy.

* Fix shell script

* Fix bug in expiration time and fix default value

* fix go mod and go sum

* update go mod and go sum

* fix go mod and go sum

* fix go mod and go sum

* Fix compatibility issues with go 1.22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants