Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restart specified component or pod #385

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

MegaByte875
Copy link
Contributor

@MegaByte875 MegaByte875 commented Nov 2, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Copy link
Contributor

@veezhang veezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veezhang
Copy link
Contributor

veezhang commented Nov 2, 2023

Maybe create an new CRD is more suitable? such as:

kind: NebulaOperation
spec:
    nebulaClusterName: xx
    nebulaClusterNamespace: xx
    action: restart
    component: storaged
    all: true or false
    ordinal: 1

In addition, it does not feel very appropriate for users to directly operate StatefulSet. StatefulSet is derived from nc and may also be overridden by operator.

@MegaByte875
Copy link
Contributor Author

Maybe create an new CRD is more suitable? such as:

kind: NebulaOperation
spec:
    nebulaClusterName: xx
    nebulaClusterNamespace: xx
    action: restart
    component: storaged
    all: true or false
    ordinal: 1

In addition, it does not feel very appropriate for users to directly operate StatefulSet. StatefulSet is derived from nc and may also be overridden by operator.

This function in alpha stage, I will adjust whether it needs to be added to CRD based on usage feedback.

@MegaByte875 MegaByte875 merged commit e05cef3 into vesoft-inc:master Nov 2, 2023
@MegaByte875 MegaByte875 deleted the restart_cluster branch November 21, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants