Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dynamic flags #310

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

MegaByte875
Copy link
Contributor

@MegaByte875 MegaByte875 commented Oct 4, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@MegaByte875
Copy link
Contributor Author

creating cluster and updating config:

    config:
      logtostder: "true"
      redirect_stdout: "false"
      rocksdb_db_options: '{"max_subcompactions":"3","max_background_jobs":"3"}'
      stderrthreshold: "0"
sh-4.2#  cat data/storage/nebula/0/0/data/LOG |grep max_background_jobs
2023/10/04-10:16:47.234764 140250029536064             Options.max_background_jobs: 3
sh-4.2#  cat data/storage/nebula/1/*/data/LOG |grep max_background_jobs
2023/10/04-10:16:47.185186 140250029536064             Options.max_background_jobs: 3
2023/10/04-10:16:47.170256 140250029536064             Options.max_background_jobs: 3
2023/10/04-10:16:47.162272 140250029536064             Options.max_background_jobs: 3
2023/10/04-10:16:47.152780 140250029536064             Options.max_background_jobs: 3
2023/10/04-10:16:47.177669 140250029536064             Options.max_background_jobs: 3

$ curl -s 10.244.1.189:19779/flags |grep rocksdb_db_options
rocksdb_db_options="{"max_subcompactions":"3","max_background_jobs":"3"}"

Copy link
Contributor

@veezhang veezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@veezhang veezhang merged commit 5d33217 into vesoft-inc:release-1.6 Oct 4, 2023
@MegaByte875 MegaByte875 deleted the fix_dynamic_flags branch October 27, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants