feat: support pvc expansion #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veezhang
reviewed
Sep 20, 2023
pkg/controller/component/helper.go
Outdated
| } | ||
| } | ||
| if oldPVC == nil { | ||
| return nil |
There was a problem hiding this comment.
If the first one is nil, then other volumeClaim and replicas do not need to be processed?
|
How about support automatic expansion? |
veezhang
reviewed
Sep 20, 2023
| @@ -504,3 +504,36 @@ func updatePod(clientSet kube.ClientSet, newPod, oldPod *corev1.Pod) error { | |||
| func isPending(pod *corev1.Pod) bool { | |||
| return pod.Status.Phase == corev1.PodPending | |||
| } | |||
|
|
|||
| // 1. new pvc is not nil, old pvc is not nil, update storage | |||
| func syncPVC( | |||
There was a problem hiding this comment.
Is it necessary to check whether pvc supports expansion?
MegaByte875
approved these changes
Sep 21, 2023
| if oldPVC == nil { | ||
| return nil | ||
| } | ||
| if volumeClaim.Spec.Resources.Requests.Storage().Cmp(*oldPVC.Spec.Resources.Requests.Storage()) != 0 { |
There was a problem hiding this comment.
What if new PVC requests less than old PVC
|
So very excited about this feature!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: