feat: add exporter rbac #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So the operator has permission to create rbac? Is this appropriate? |
veezhang
reviewed
Aug 16, 2023
| ) | ||
|
|
||
| func (e *nebulaExporter) checkExporterRBAC(nc *v1alpha1.NebulaCluster) error { | ||
| if err := e.createServiceAccount(nc); err != nil { |
There was a problem hiding this comment.
The rbac of operaotor seems not to be updated, because you need new permissions?
MegaByte875
approved these changes
Aug 22, 2023
Comment on lines
227
to
231
| Collect string `json:"collect,omitempty"` | ||
|
|
||
| // Ingore means the regex to ignore metrics | ||
| // +optional | ||
| Ignore string `json:"ignore,omitempty"` |
There was a problem hiding this comment.
I think CollectedRegex and IgnoredRegex more appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
support metrics filter
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: