Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nebula-operator cannot set the annotations of service] nebula-operator中没有处理service里面的annotations,没办法增加自定义的label到service的annotations里面 #113

Closed
woaiwah opened this issue Feb 9, 2022 · 12 comments · Fixed by #119

Comments

@woaiwah
Copy link

woaiwah commented Feb 9, 2022

No description provided.

@veezhang
Copy link
Contributor

@woaiwah
Emm, thanks for your feedback, there is indeed no assignment here. Can you try to help submit a pr?

https://github.com/vesoft-inc/nebula-operator/blob/master/apis/apps/v1alpha1/nebulacluster_common.go#L413-L421

@woaiwah
Copy link
Author

woaiwah commented Feb 10, 2022

@veezhang
So sorry!I don't know much about go language. I hope you can help solve this problem

@woaiwah
Copy link
Author

woaiwah commented Feb 10, 2022

@veezhang Line 383, func generateService(c NebulaClusterComponentter) *corev1.Service

@veezhang
Copy link
Contributor

veezhang commented Feb 10, 2022

@woaiwah
Thanks, we're going to fix it.
If you are in a hurry, you can create a new service and then set annotations to it . Not sure if this can help you?

For example,

You can get the get the service resource definition via kubectl get xxx-graphd-svc -oyaml > xxx-graphd-svc.yaml.

Then open the xxx-graphd-svc.yaml, change the name, and set your annotations.

And create it by kubectl create -f xxx-graphd-svc.yaml.

@veezhang
Copy link
Contributor

@woaiwah
What are you setting annotations for? I'll see if I can help you.

@woaiwah
Copy link
Author

woaiwah commented Feb 10, 2022

The internal k8s cluster of our company is managed by the operation and maintenance department. When I use k8s cluster deployment,I need to add a customized annotation of the operation and maintenance department, so as to comply with their rules. So i need to setting annotations in service

@veezhang
Copy link
Contributor

@woaiwah Emm, you must set the annotations for all the service ?

@woaiwah
Copy link
Author

woaiwah commented Feb 10, 2022

@woaiwah Emm, you must set the annotations for all the service ?

Yes,deployment nebula-cluster,only graphd-svc needs

@veezhang
Copy link
Contributor

veezhang commented Feb 10, 2022

@woaiwah
You just need to add annotations for graphd-svc, similar to exposing, making it accessible to the outside kubernetes?
Can you add an new service xxx-graphd-svc-new with the annotations?

If not, then you may have to wait for the issue to be fixed.

@woaiwah
Copy link
Author

woaiwah commented Feb 10, 2022

similar to exposing, making it accessible to the outside kubernetes

Yes , you are right,Now I'm try to add an new service nebula-graphd-svc-new with the annotations, I don't know if I can succeed,This way will make graphd have two service。 Let me try。

@veezhang
Copy link
Contributor

similar to exposing, making it accessible to the outside kubernetes

Yes , you are right,Now I'm try to add an new service nebula-graphd-svc-new with the annotations, I don't know if I can succeed,This way will make graphd have two service。 Let me try。
@woaiwah
Emm, Two Services are fully allowed. You can try it out and contact us if you need support.

@veezhang veezhang changed the title nebula-operator中没有处理service里面的annotations,没办法增加自定义的label到service的annotations里面 [nebula-operator cannot set the annotations of service] nebula-operator中没有处理service里面的annotations,没办法增加自定义的label到service的annotations里面 Feb 11, 2022
@woaiwah
Copy link
Author

woaiwah commented Feb 16, 2022

You can try it out and contact us if you need support
Follow the above method,Two Services,and It can be used normally

veezhang added a commit to veezhang/nebula-operator that referenced this issue Mar 8, 2022
@veezhang veezhang mentioned this issue Mar 8, 2022
veezhang added a commit that referenced this issue Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants