Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the leader state for CANDIDATE meta role #502

Merged
merged 2 commits into from
Dec 30, 2022

Conversation

Nicole00
Copy link
Contributor

@Nicole00 Nicole00 commented Dec 29, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

fix #409

Description:

How do you solve it?

When the leader host in response is empty, then fresh the meta client with input addresses. When the leader host is not empty, just use the leader host to update the meta client.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@codecov-commenter
Copy link

Codecov Report

Base: 63.46% // Head: 63.72% // Increases project coverage by +0.25% 🎉

Coverage data is based on head (e904e37) compared to base (e25c56d).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #502      +/-   ##
============================================
+ Coverage     63.46%   63.72%   +0.25%     
- Complexity      787      792       +5     
============================================
  Files            71       71              
  Lines          3758     3760       +2     
  Branches        537      538       +1     
============================================
+ Hits           2385     2396      +11     
+ Misses         1004      998       -6     
+ Partials        369      366       -3     
Impacted Files Coverage Δ
...java/com/vesoft/nebula/client/meta/MetaClient.java 57.14% <33.33%> (+4.25%) ⬆️
...va/com/vesoft/nebula/client/graph/SessionPool.java 58.19% <0.00%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nicole00 Nicole00 requested a review from HarrisChu December 30, 2022 02:44
@Nicole00 Nicole00 merged commit 6f5e897 into vesoft-inc:master Dec 30, 2022
@Nicole00 Nicole00 deleted the metaclient branch December 30, 2022 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Cannot open null host" log by com.vesoft.nebula.client.meta.MetaManager
3 participants