Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to release the invalid session for SessionPool #499

Merged
merged 5 commits into from
Dec 20, 2022

Conversation

Nicole00
Copy link
Contributor

@Nicole00 Nicole00 commented Dec 19, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#498

Description:

How do you solve it?

try the session's signOut process, make sure the session release not throw exception but just print the warn log.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Base: 63.37% // Head: 63.46% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (e6af8a5) compared to base (70d260b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #499      +/-   ##
============================================
+ Coverage     63.37%   63.46%   +0.09%     
  Complexity      787      787              
============================================
  Files            71       71              
  Lines          3754     3758       +4     
  Branches        537      537              
============================================
+ Hits           2379     2385       +6     
+ Misses         1006     1002       -4     
- Partials        369      371       +2     
Impacted Files Coverage Δ
.../vesoft/nebula/client/graph/SessionPoolConfig.java 49.09% <ø> (ø)
.../com/vesoft/nebula/client/graph/NebulaSession.java 75.00% <100.00%> (+5.00%) ⬆️
...vesoft/nebula/client/graph/net/SyncConnection.java 54.09% <0.00%> (ø)
...va/com/vesoft/nebula/client/graph/SessionPool.java 57.62% <0.00%> (+1.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nicole00 Nicole00 merged commit a719bd5 into vesoft-inc:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants