support geo encoder #380
support geo encoder #380
Conversation
jievince
force-pushed
the
geo
branch
17 times, most recently
from
047f35c to
e12c08a
Compare
Codecov Report
@@ Coverage Diff @@
## master #380 +/- ##
============================================
+ Coverage 63.43% 63.73% +0.30%
- Complexity 692 705 +13
============================================
Files 65 65
Lines 3274 3337 +63
Branches 459 471 +12
============================================
+ Hits 2077 2127 +50
- Misses 883 888 +5
- Partials 314 322 +8
Continue to review full report at Codecov.
|
client/src/main/java/com/vesoft/nebula/encoder/RowWriterImpl.java
Outdated
Show resolved
Hide resolved
| List<List<Coordinate>> rings = new ArrayList<List<Coordinate>>(); | ||
| rings.add(shell); | ||
| rings.add(hole); | ||
| geogPolygonVal.setGgVal(Geography.pgVal(new Polygon(rings))); |
There was a problem hiding this comment.
please add test for null geograph value.
There was a problem hiding this comment.
It's not a need, because null geo value is no different from other types. And TestEncoder.java also just test null value of int64
There was a problem hiding this comment.
It's necessary, it happens out of bound error before for null string value int the properties. So you should add test like there are three geography properties but one is null to avoid that problem.
jievince
force-pushed
the
geo
branch
3 times, most recently
from
6daaf9d to
61a114a
Compare
* support geo encoder * debug * remove debug log * let WKBWriter use machine byte order * add null test for geo * debug * format code
No description provided.