throw exception when listHosts failed (#606)

vesoft-inc · Oct 22, 2024 · 7edea2f · 7edea2f
1 parent c3fa62a
commit 7edea2f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/client/src/main/java/com/vesoft/nebula/client/meta/MetaClient.java b/client/src/main/java/com/vesoft/nebula/client/meta/MetaClient.java
@@ -457,11 +457,11 @@ public synchronized Set<HostAddr> listHosts() {
             }
         } catch (TException e) {
             LOGGER.error("listHosts error", e);
-            return null;
+            throw new RuntimeException("listHosts error", e);
         }
         if (resp.getCode() != ErrorCode.SUCCEEDED) {
             LOGGER.error("listHosts execute failed, errorCode: " + resp.getCode());
-            return null;
+            throw new RuntimeException("listHosts execute failed, errorCode:" + resp.getCode());
         }
         Set<HostAddr> hostAddrs = new HashSet<>();
         for (HostItem hostItem : resp.hosts) {

diff --git a/client/src/main/java/com/vesoft/nebula/client/meta/MetaManager.java b/client/src/main/java/com/vesoft/nebula/client/meta/MetaManager.java
@@ -393,9 +393,6 @@ public void updateLeader(String spaceName, int part, HostAddr newLeader)
      */
     public Set<HostAddr> listHosts() {
         Set<HostAddr> hosts = metaClient.listHosts();
-        if (hosts == null) {
-            return new HashSet<>();
-        }
         if (!storageAddressMapping.isEmpty()) {
             hosts = hosts
                     .stream()