Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add filter #274

Merged
merged 1 commit into from
Jun 8, 2023
Merged

feat: add filter #274

merged 1 commit into from
Jun 8, 2023

Conversation

veezhang
Copy link
Contributor

@veezhang veezhang commented Jun 7, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#271

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@veezhang veezhang requested review from yixinglu and Aiee as code owners June 7, 2023 06:00
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 94.16% and project coverage change: +0.10 🎉

Comparison is base (1cd45ee) 90.20% compared to head (5c49e51) 90.30%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
+ Coverage   90.20%   90.30%   +0.10%     
==========================================
  Files          75       76       +1     
  Lines        3350     3426      +76     
==========================================
+ Hits         3022     3094      +72     
- Misses        323      326       +3     
- Partials        5        6       +1     
Impacted Files Coverage Δ
pkg/spec/base/builder_mock.go 0.00% <0.00%> (ø)
pkg/importer/importer.go 95.38% <57.14%> (-4.62%) ⬇️
pkg/errors/import.go 100.00% <100.00%> (ø)
pkg/manager/manager.go 100.00% <100.00%> (ø)
pkg/spec/base/builder.go 100.00% <100.00%> (ø)
pkg/spec/base/filter.go 100.00% <100.00%> (ø)
pkg/spec/v3/edge.go 100.00% <100.00%> (ø)
pkg/spec/v3/graph.go 100.00% <100.00%> (ø)
pkg/spec/v3/node.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yixinglu yixinglu merged commit 2f92e06 into vesoft-inc:master Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants