feat: add picker to pick value from record #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veezhang
force-pushed
the
feat
branch
2 times, most recently
from
bddedbf to
9aa677d
Compare
kqzh
reviewed
Dec 14, 2022
| package picker | ||
|
|
||
| var _ Picker = ConverterPicker{} | ||
|
|
There was a problem hiding this comment.
add var _ Picker = NullablePickers{} too ?
veezhang
added a commit
to veezhang/nebula-importer
that referenced
this pull request
Dec 14, 2022
veezhang
added a commit
to veezhang/nebula-importer
that referenced
this pull request
Dec 14, 2022
kqzh
reviewed
Dec 14, 2022
Comment on lines
+46
to
+51
| case 0: | ||
| return v, nil | ||
| case 1: | ||
| return ncs[0].Convert(v) | ||
| } | ||
| return ncs.convertSlow(v) |
There was a problem hiding this comment.
No need to process case1?
if len(nsc) == 0 {
return v, nil
}
return ncs.convertSlow(v)
There was a problem hiding this comment.
It‘s for performance. It's need not to loop.
Comment on lines
+21
to
+27
| switch len(cs) { | ||
| case 0: | ||
| return v, nil | ||
| case 1: | ||
| return cs[0].Convert(v) | ||
| } | ||
| return cs.convertSlow(v) |
There was a problem hiding this comment.
Same as #246 (comment) .
Comment on lines
+63
to
+79
| if !nullHandled && c.Nullable != nil { | ||
| converters = append(converters, NullableConverter{ | ||
| Nullable: c.Nullable, | ||
| }) | ||
| } | ||
|
|
||
| if c.Nullable != nil { | ||
| if c.DefaultValue != nil { | ||
| converters = append(converters, DefaultConverter{ | ||
| Value: *c.DefaultValue, | ||
| }) | ||
| } else { | ||
| converters = append(converters, NullConverter{ | ||
| Value: c.NullValue, | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
can combine them ?
if c.Nullable != nil {
if !nullHandled {
converters = append(converters, NullableConverter{
Nullable: c.Nullable,
})
}
if c.DefaultValue != nil {
converters = append(converters, DefaultConverter{
Value: *c.DefaultValue,
})
} else {
converters = append(converters, NullConverter{
Value: c.NullValue,
})
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
Ref #245
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: