Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for wildcard filename #153

Merged
merged 7 commits into from
Jul 23, 2021
Merged

add support for wildcard filename #153

merged 7 commits into from
Jul 23, 2021

Conversation

IanSmith123
Copy link
Contributor

No description provided.

@IanSmith123 IanSmith123 requested a review from yixinglu as a code owner July 21, 2021 14:55
@CLAassistant
Copy link

CLAassistant commented Jul 21, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

yixinglu
yixinglu reviewed Jul 22, 2021
View reviewed changes
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
@IanSmith123
Copy link
Contributor Author

Thanks for your review, I have made changes based on your suggestions.

@IanSmith123
Copy link
Contributor Author

Thanks for your review, I have made changes based on your suggestions again. 😃

yixinglu
yixinglu approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!!

@yixinglu yixinglu merged commit c282b72 into vesoft-inc:master Jul 23, 2021
@jamieliu1023 jamieliu1023 mentioned this pull request Jul 24, 2021
Closed
@IanSmith123 IanSmith123 mentioned this pull request Aug 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yixinglu yixinglu yixinglu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IanSmith123 @CLAassistant @yixinglu