Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support default value while import #125

Closed
wants to merge 4 commits into from

Conversation

xuhuijun
Copy link

we are migrating data from neo4j to nebula by using csv file. There is one field which type is bool. In neo4j export csv file, the value could be true/false/empty. In such case, importing failed due to nebula reject empty value.

So we need to add default value while filed value is missing. Below is the example we want:

data.csv:
100,true,
101,,

Schema definition:
schema:
type: vertex
vertex:
tags:
- name: collection
props:
- name: used
type: bool
default: false

The second line in data will use default value false and below will load to nebula:
100(true)
101(false)

@xuhuijun xuhuijun requested a review from yixinglu as a code owner April 15, 2021 07:27
@CLAassistant
Copy link

CLAassistant commented Apr 15, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ HarrisChu
✅ Aiee
❌ xuhuijun
You have signed the CLA already but the status is still pending? Let us recheck it.

@yixinglu
Copy link
Contributor

Thanks @xuhuijun

Could you add some test data in the examples folder to test the feature ?

In addition, don't forget to sign the CLA by click the badge in above comment.

@Sophie-Xie Sophie-Xie requested a review from veezhang November 29, 2022 09:39
@veezhang
Copy link
Contributor

veezhang commented Dec 7, 2022

@xuhuijun Thanks!I create an PR #243 to support default value, and thanks again and again.

@veezhang veezhang closed this Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants