maybe should check the result of filepath.Glob() and return an error (#…

…265) * fix: return error while check file doesn't exist --------- Co-authored-by: Vee Zhang <[email protected]>
vesoft-inc · May 17, 2023 · 4eeb7d0 · 4eeb7d0
1 parent 4cd85fb
commit 4eeb7d0
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/pkg/config/config.go b/pkg/config/config.go
@@ -232,9 +232,7 @@ func (config *YAMLConfig) expandDirectoryToFiles(dir string) (err error) {
 			logger.Log.Errorf("error when expand file: %s", err)
 			return err
 		}
-		for _, f := range files {
-			newFiles = append(newFiles, f)
-		}
+		newFiles = append(newFiles, files...)
 	}
 	config.Files = newFiles
 
@@ -408,11 +406,15 @@ func (f *File) expandFiles(dir string) ([]*File, error) {
 		}
 
 		fileNames, err := filepath.Glob(*f.Path)
-		if err != nil || len(fileNames) == 0 {
+		if err != nil {
 			logger.Log.Errorf("error file path: %s", *f.Path)
 			return files, err
 		}
 
+		if len(fileNames) == 0 {
+			return files, &os.PathError{Op: "open", Path: *f.Path, Err: os.ErrNotExist}
+		}
+
 		for i := range fileNames {
 			var failedDataPath *string = nil
 			if f.FailDataPath != nil {