Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

Feature/fetch vertices on multi tags #310

Merged
merged 11 commits into from
Nov 16, 2020
Merged

Feature/fetch vertices on multi tags #310

merged 11 commits into from
Nov 16, 2020

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented Sep 29, 2020 •
edited
Loading

@Shylock-Hg Shylock-Hg added the ready-for-testing PR: ready for the CI test label Sep 29, 2020
@Shylock-Hg Shylock-Hg requested a review from a team September 29, 2020 08:46
laura-ding
laura-ding reviewed Oct 15, 2020
View reviewed changes
Copy link
Contributor

@laura-ding laura-ding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see the fetch multi edges in the python test

src/parser/TraverseSentences.h Show resolved Hide resolved
@Shylock-Hg Shylock-Hg requested review from laura-ding and a team October 15, 2020 02:47
yixinglu
yixinglu reviewed Oct 21, 2020
View reviewed changes
tests/query/v1/test_fetch_vertex.py Outdated Show resolved Hide resolved
src/parser/Clauses.h Show resolved Hide resolved
@Shylock-Hg Shylock-Hg requested review from yixinglu and a team October 21, 2020 05:39
yixinglu
yixinglu previously approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shylock-Hg Shylock-Hg requested a review from a team October 23, 2020 05:27
laura-ding
laura-ding previously approved these changes Oct 23, 2020
View reviewed changes
@dutor
Copy link
Contributor

dutor commented Oct 24, 2020

Please resolve the conflicts.

@Shylock-Hg Shylock-Hg dismissed stale reviews from laura-ding and yixinglu via 546edae October 26, 2020 02:00
@Shylock-Hg Shylock-Hg requested review from yixinglu, laura-ding and a team October 26, 2020 02:01
@Shylock-Hg
Copy link
Contributor Author

Please resolve the conflicts.

Fixed.

CPWstatic
CPWstatic approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@CPWstatic CPWstatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yixinglu yixinglu added the doc affected Solution: improvements or additions to documentation label Nov 15, 2020
@yixinglu yixinglu merged commit 357746a into vesoft-inc:master Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CPWstatic CPWstatic CPWstatic approved these changes

@yixinglu yixinglu yixinglu approved these changes

@laura-ding laura-ding Awaiting requested review from laura-ding

Assignees
No one assigned
Labels
doc affected Solution: improvements or additions to documentation ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Shylock-Hg @dutor @yixinglu @CPWstatic @laura-ding