This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
Check whether index is valid at runtime #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixinglu
requested review from
nevermore3,
CPWstatic,
Aiee,
czpmango,
Shylock-Hg,
jievince,
laura-ding and
bright-starry-sky
jievince
approved these changes
Jul 28, 2021
Aiee
approved these changes
Jul 28, 2021
Comment on lines
+33
to
+40
|
|
||
| const auto &ictxs = lookup->queryContext(); | ||
| auto iter = std::find_if( | ||
| ictxs.begin(), ictxs.end(), [](auto &ictx) { return !ictx.index_id_ref().is_set(); }); | ||
| if (ictxs.empty() || iter != ictxs.end()) { | ||
| return Status::Error("There is no index to use at runtime"); | ||
| } | ||
|
|
There was a problem hiding this comment.
Why is the index ID not set?
There was a problem hiding this comment.
Now index is selected in multiple opt rules. when all rules could not select the index, IndexFullScanNode without index is still in the execution plan. so here needs to check the real index at runtime.
|
In addition, maybe need to check the validity of the index. for example : |
| const auto &ictxs = lookup->queryContext(); | ||
| auto iter = std::find_if( | ||
| ictxs.begin(), ictxs.end(), [](auto &ictx) { return !ictx.index_id_ref().is_set(); }); | ||
| if (ictxs.empty() || iter != ictxs.end()) { |
There was a problem hiding this comment.
Is the checking logic in the if statement ictxs.empty() necessary?
There was a problem hiding this comment.
My test cases is for this scenario.
Now if you use |
CPWstatic
pushed a commit
to CPWstatic/nebula-graph
that referenced
this pull request
Aug 2, 2021
* Check whether index is valid at runtime * Fix failed ut * Fix steps * drop the used space * Format
CPWstatic
added a commit
that referenced
this pull request
Aug 3, 2021
* Fix the go return bad_type when the vertex without the tag (#1273) Co-authored-by: Yee <[email protected]> * fix util functions (#1277) small delete * Check whether index is valid at runtime (#1291) * Check whether index is valid at runtime * Fix failed ut * Fix steps * drop the used space * Format * Replace the lastUser by user count.… (#1243) * Replace the lastUser by user count.The last user maybe could run simultaneously, so can't determine which is real last user in timeline. * Fix the typo. Co-authored-by: Yee <[email protected]> * fix first plan node input var (#1298) Co-authored-by: laura-ding <[email protected]> Co-authored-by: Yee <[email protected]> Co-authored-by: kyle.cao <[email protected]> Co-authored-by: Shylock Hg <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title.