This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
fix the wrong usage of limit sentence #1222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shylock-Hg
reviewed
Jul 8, 2021
Shylock-Hg
reviewed
Jul 8, 2021
jievince
force-pushed
the
limit
branch
4 times, most recently
from
aa12640 to
7814d49
Compare
Aiee
reviewed
Jul 12, 2021
Shylock-Hg
reviewed
Jul 13, 2021
Shylock-Hg
added
the
doc affected
Shylock-Hg
reviewed
Jul 15, 2021
Shylock-Hg
reviewed
Jul 15, 2021
Aiee
previously approved these changes
Jul 16, 2021
yixinglu
previously approved these changes
Jul 26, 2021
CPWstatic
previously approved these changes
Aug 10, 2021
CPWstatic
dismissed stale reviews from yixinglu, Aiee, and themself
The base branch was changed.
CPWstatic
pushed a commit
that referenced
this pull request
Aug 11, 2021
* fix the wrong usage of limit sentence * add some tck tests * support order by with variable * address comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
limit_sentencecould only be used after|close #1216