Generate log directory if not exist (#873)

Co-authored-by: Yee <[email protected]>
vesoft-inc · Mar 25, 2021 · eb06442 · eb06442
1 parent 3c66147
commit eb06442
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/conf/nebula-graphd.conf.default b/conf/nebula-graphd.conf.default
@@ -7,7 +7,7 @@
 --enable_optimizer=true
 
 ########## logging ##########
-# The directory to host logging files, which must already exists
+# The directory to host logging files
 --log_dir=logs
 # Log level, 0, 1, 2, 3 for INFO, WARNING, ERROR, FATAL respectively
 --minloglevel=0

diff --git a/conf/nebula-graphd.conf.production b/conf/nebula-graphd.conf.production
@@ -7,7 +7,7 @@
 --enable_optimizer=true
 
 ########## logging ##########
-# The directory to host logging files, which must already exists
+# The directory to host logging files
 --log_dir=logs
 # Log level, 0, 1, 2, 3 for INFO, WARNING, ERROR, FATAL respectively
 --minloglevel=0

diff --git a/src/daemons/GraphDaemon.cpp b/src/daemons/GraphDaemon.cpp
@@ -25,6 +25,7 @@ using nebula::Status;
 using nebula::ProcessUtils;
 using nebula::graph::GraphService;
 using nebula::network::NetworkUtils;
+using nebula::fs::FileUtils;
 
 static std::unique_ptr<apache::thrift::ThriftServer> gServer;
 
@@ -197,6 +198,14 @@ void signalHandler(int sig) {
 
 
 Status setupLogging() {
+    // If the log directory does not exist, try to create
+    if (!FileUtils::exist(FLAGS_log_dir)) {
+        if (!FileUtils::makeDir(FLAGS_log_dir)) {
+            return Status::Error("Failed to create log directory `%s'",
+                                 FLAGS_log_dir.c_str());
+        }
+    }
+
     if (!FLAGS_redirect_stdout) {
         return Status::OK();
     }