Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support scan Nebula subgraph results (vertex and edge) and slice of struct ptr #346

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Support scan Nebula subgraph results (vertex and edge) and slice of struct ptr #346

wants to merge 6 commits into from

Conversation

haoxins
Copy link
Collaborator

@haoxins haoxins commented Jun 26, 2024 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@haoxins
Copy link
Collaborator Author

haoxins commented Jun 26, 2024

need to add some tests

@haoxins
Copy link
Collaborator Author

haoxins commented Jun 26, 2024

ok, at least I didn't break anything 😂

@haoxins haoxins changed the title Support scan Nebula vertex and edge Support scan Nebula subgraph results (vertex and edge) Jun 26, 2024
@haoxins haoxins marked this pull request as draft June 27, 2024 06:01
@haoxins haoxins force-pushed the feat-nest-struct branch 5 times, most recently from 8d1cfc0 to ed2ca89 Compare June 29, 2024 12:49
@wey-gu wey-gu requested review from HarrisChu and Nicole00 June 29, 2024 15:07
@haoxins haoxins force-pushed the feat-nest-struct branch 2 times, most recently from 222d26e to 62da147 Compare June 29, 2024 16:56
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 63.10680% with 38 lines in your changes missing coverage. Please review.

Project coverage is 64.41%. Comparing base (4e4de32) to head (b6d665c).

Files with missing lines Patch % Lines
result_set.go 63.10% 30 Missing and 8 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
+ Coverage   64.36%   64.41%   +0.05%     
==========================================
  Files          11       11              
  Lines        2963     3041      +78     
==========================================
+ Hits         1907     1959      +52     
- Misses        897      915      +18     
- Partials      159      167       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haoxins haoxins force-pushed the feat-nest-struct branch 14 times, most recently from 33f24f7 to 686edf3 Compare June 30, 2024 15:24
@wey-gu
Copy link
Contributor

wey-gu commented Jul 1, 2024

@haoxins is this still in draft state or?

@haoxins
Copy link
Collaborator Author

haoxins commented Jul 1, 2024

@haoxins is this still in draft state or?

draft, I need to add some basic tests later

@haoxins haoxins marked this pull request as ready for review July 7, 2024 11:48
@haoxins
Copy link
Collaborator Author

haoxins commented Jul 7, 2024

ready to go~

@wey-gu wey-gu requested review from HarrisChu and kqzh and removed request for HarrisChu July 7, 2024 11:57
wey-gu
wey-gu previously approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@wey-gu wey-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!∠(°ゝ°)

@wey-gu wey-gu requested review from Nicole00 and removed request for Nicole00 July 26, 2024 00:10
@wey-gu
Copy link
Contributor

wey-gu commented Jul 26, 2024

@Nicole00 kindly take a review on this work, please? 😊

@haoxins
Copy link
Collaborator Author

haoxins commented Sep 12, 2024

hello, any advice?

@haoxins haoxins requested a review from wey-gu September 19, 2024 09:30
wey-gu
wey-gu previously approved these changes Sep 21, 2024
View reviewed changes
@wey-gu
Copy link
Contributor

wey-gu commented Sep 21, 2024

@HarrisChu @Nicole00

@haoxins
Copy link
Collaborator Author

haoxins commented Sep 27, 2024

hello, is it possible to finish this before the Oct holiday? 😂

@haoxins haoxins changed the title Support scan Nebula subgraph results (vertex and edge) Support scan Nebula subgraph results (vertex and edge) and slice of struct ptr Nov 4, 2024
@haoxins
Copy link
Collaborator Author

haoxins commented Nov 4, 2024

The failed test seems not relevant to this PR's changes
https://github.com/vesoft-inc/nebula-go/actions/runs/11659550672/job/32460307401?pr=346#step:4:620

@wey-gu
Copy link
Contributor

wey-gu commented Nov 4, 2024

@HarrisChu @Nicole00 can we move this further in this week?

@haoxins
Copy link
Collaborator Author

haoxins commented Dec 3, 2024

@HarrisChu @Nicole00 can we move this further in this week?

@Nicole00 can we move forward? not sure the failed UTs reasons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wey-gu wey-gu wey-gu left review comments

@HarrisChu HarrisChu Awaiting requested review from HarrisChu

@kqzh kqzh Awaiting requested review from kqzh

@Nicole00 Nicole00 Awaiting requested review from Nicole00

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haoxins @codecov-commenter @wey-gu