Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateTag and CreateEdge support TTL #328

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

haoxins
Copy link
Collaborator

@haoxins haoxins commented Apr 2, 2024

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@haoxins haoxins force-pushed the schema_manager_ttl branch 5 times, most recently from c052370 to dd02f8e Compare April 2, 2024 06:38
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 87.27273% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 65.16%. Comparing base (7953667) to head (3a07d21).

Files Patch % Lines
label.go 88.57% 3 Missing and 1 partial ⚠️
session_pool.go 66.66% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
+ Coverage   64.94%   65.16%   +0.22%     
==========================================
  Files          11       11              
  Lines        2784     2822      +38     
==========================================
+ Hits         1808     1839      +31     
- Misses        825      830       +5     
- Partials      151      153       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haoxins haoxins force-pushed the schema_manager_ttl branch from dd02f8e to 01e4aed Compare April 2, 2024 07:10
@haoxins haoxins changed the title AddTag/AddEdge support TTL CreateTag/AddEdge support TTL Apr 2, 2024
@haoxins haoxins changed the title CreateTag/AddEdge support TTL CreateTag/CreateEdge support TTL Apr 2, 2024
@haoxins haoxins force-pushed the schema_manager_ttl branch 2 times, most recently from a16ccc5 to 3a07d21 Compare April 2, 2024 07:23
label.go Show resolved Hide resolved
@haoxins haoxins force-pushed the schema_manager_ttl branch 3 times, most recently from 00cd086 to 3764bf4 Compare April 2, 2024 08:17
@haoxins haoxins changed the title CreateTag/CreateEdge support TTL CreateTag and CreateEdge support TTL Apr 2, 2024
Supports build QL with TTL

wip

fix

docs

fix
@haoxins haoxins force-pushed the schema_manager_ttl branch from 3764bf4 to d24c848 Compare April 2, 2024 08:22
@haoxins haoxins marked this pull request as ready for review April 2, 2024 08:27
@haoxins haoxins requested a review from Nicole00 April 2, 2024 08:27
@Nicole00 Nicole00 merged commit 150403c into vesoft-inc:master Apr 2, 2024
23 checks passed
@haoxins haoxins deleted the schema_manager_ttl branch April 2, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants